Run amp-linter checks as part of this module #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickkettner
approved these changes
Mar 12, 2021
| @@ -0,0 +1 @@ | |||
| gcloud functions deploy checkFonts --entry-point demo/index.js --runtime nodejs14 --trigger-http --allow-unauthenticated --project amp-dev-staging | |||
There was a problem hiding this comment.
are we explicitly needing 14 vs latest stable?
There was a problem hiding this comment.
No, but you need to pick a runtime and 14 is the latest supported one.
There was a problem hiding this comment.
Oh? The docs read like you could just declare nodejs. 👍
| @@ -178,6 +181,7 @@ class PageAnalyzer { | |||
| }; | |||
|
|
|||
| return { | |||
| url: window.location, | |||
There was a problem hiding this comment.
url is the location object? not window.location.href?
There was a problem hiding this comment.
good one! fixed
sebastianbenz
force-pushed
the
px-linter
branch
from
77ad5bc
to
163df7a
Compare
sebastianbenz
force-pushed
the
px-linter
branch
from
163df7a
to
f712fdd
Compare
renovate-bot
pushed a commit
to renovate-bot/amp-toolbox
that referenced
this pull request
Mar 12, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.