Enable amp-img => img transformation for hero images #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
reviewed
Aug 1, 2020
| @@ -320,6 +316,7 @@ class PreloadHeroImage { | |||
| } | |||
| } | |||
| node.attribs['i-amphtml-ssr'] = ''; | |||
| node.attribs['data-hero'] = ''; | |||
There was a problem hiding this comment.
Is this added just so developers are aware of the element that was identified as the hero? It's not required for validation as far as I can tell.
Co-authored-by: Weston Ruter <westonruter@google.com>
|
Thanks Weston! |
tharders
pushed a commit
that referenced
this pull request
Aug 17, 2020
* Enable amp-img => img transformation for hero images * update readme * mark generated hero images * Improve readme Co-authored-by: Weston Ruter <westonruter@google.com> Co-authored-by: Weston Ruter <westonruter@google.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.