Stop Preact from exposing VNode as ref #33500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
approved these changes
Mar 26, 2021
| @@ -79,6 +79,19 @@ describes.realWin('PreactBaseElement', {amp: true}, (env) => { | |||
| }); | |||
| } | |||
|
|
|||
| it('preact ref passing vnode smoke test', () => { | |||
There was a problem hiding this comment.
Incredibly smart test for guaranteeing we clean up the hack. A+ I'm very impressed
rochapablo
pushed a commit
to rochapablo/amphtml
that referenced
this pull request
Aug 30, 2021
* Stop Preact from exposing VNode as ref * Add a smoke test * Fix check
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hacky (only need in local dev) workaround for preactjs/preact#3084.