-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: timeout issues in gremlinpython==3.4.9 #17
Conversation
Signed-off-by: Rajat Jaiswal <rajat.jaiswal@hotstar.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to bump the version to use this change downstream, but seems reasonable to me!
@rajat499 could you bump the version as suggested by @friendtocephalopods ? |
Signed-off-by: Rajat Jaiswal <rajat.jaiswal@hotstar.com>
@feng-tao Sure. Done. |
@feng-tao @friendtocephalopods I just checked that the timeout issue was fixed in v |
is there any api change from 3.4.9 to 3.4.10? |
No, there isn't any change in the API. They have added some new functionalities for java but nothing for python. |
cool, make sense to upgrade then. |
* Fix timeout issues in tornado Signed-off-by: Rajat Jaiswal <rajat.jaiswal@hotstar.com> * Bump the version Signed-off-by: Rajat Jaiswal <rajat.jaiswal@hotstar.com> Signed-off-by: Amom <amommendes@hotmail.com>
Summary of Changes
gremlinpython==3.4.9
has default timeout set to 30 seconds, which causes WebSockets to timeout without completing the requests. Fix has been taken from the below references.Reference: https://groups.google.com/g/gremlin-users/c/K0EVG3T-UrM/m/51bfkOZOCgAJ
apache/tinkerpop@3f93fdc
This is likely fixed in
gremlinpython==3.5.0
but since we are using3.4.9
this fix is required. We can't usegremlinpython==3.5.0
for now. Please refer: #16A similar PR was merged in metadata service for the same issue: amundsen-io/amundsen#1334
CheckList
Make sure you have checked all steps below to ensure a timely review.