scripts: adi_env: Update Vivado to 2024.2 version #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladace
requested review from
acostina,
AndreiGrozav,
PopPaul2021,
gastmaier and
sarpadi
as code owners
ladace
requested review from
IuliaCMoldovan,
AndrDragomir,
FilipG24,
bluncan and
podgori
as code owners
ladace
force-pushed
the
dev_vivado_2024_2
branch
from
dee7ccf to
b2f9217
Compare
ladace
force-pushed
the
dev_vivado_2024_2
branch
from
b2f9217 to
61363bb
Compare
|
V1:
|
Comment on lines
+21
to
+23
| set_property used_in_simulation false [get_files ./../scripts/adi_xilinx_device_info_enc.tcl] | ||
| set_property used_in_synthesis false [get_files ./bd/bd.tcl] | ||
| set_property used_in_synthesis false [get_files ./../scripts/adi_xilinx_device_info_enc.tcl] |
There was a problem hiding this comment.
Wouldn't it be better if it was written with the $ad_hdl_dir, since it anyway is used at line 8?
Suggested change
| set_property used_in_simulation false [get_files ./../scripts/adi_xilinx_device_info_enc.tcl] | |
| set_property used_in_synthesis false [get_files ./bd/bd.tcl] | |
| set_property used_in_synthesis false [get_files ./../scripts/adi_xilinx_device_info_enc.tcl] | |
| set_property used_in_simulation false [get_files $ad_hdl_dir/library/scripts/adi_xilinx_device_info_enc.tcl] | |
| set_property used_in_synthesis false [get_files ./bd/bd.tcl] | |
| set_property used_in_synthesis false [get_files $ad_hdl_dir/library/scripts/adi_xilinx_device_info_enc.tcl] |
|
RetriggerCI |
ladace
force-pushed
the
dev_vivado_2024_2
branch
from
61363bb to
a5fc727
Compare
|
V2:
|
Signed-off-by: Liviu 'Ceshu' Adace <liviu.adace@analog.com>
Fixes for: CRITICAL WARNING: [IP_Flow 19-991] Unrecognized or unsupported file 'bd/bd.tcl' found in file group 'Synthesis'. CRITICAL WARNING: [IP_Flow 19-991] Unrecognized or unsupported file 'bd/bd.tcl' found in file group 'Simulation'. Signed-off-by: Liviu 'Ceshu' Adace <liviu.adace@analog.com>
Fixes for: CRITICAL WARNING: [IP_Flow 19-1965] Bus Interface 'xyz': A port map to the required logical port "abc" of the bus abstraction "analog.com:interface:'interface':1.0" is missing. Signed-off-by: Liviu 'Ceshu' Adace <liviu.adace@analog.com>
ladace
force-pushed
the
dev_vivado_2024_2
branch
from
c066c77 to
04bc41e
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Update Xilinx tools to 2024.2 version
PR Type
PR Checklist