Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

library.mk: Fix second run for dependent lib #1626

Merged
merged 1 commit into from
Mar 31, 2025
Merged

library.mk: Fix second run for dependent lib #1626

merged 1 commit into from
Mar 31, 2025

Conversation

AndreiGrozav
Copy link
Contributor

Starting from when thread building was added, the libraries are only building once After the target file is created it does not go further with checking dates.

This change forces the make through a phony target to properly evaluate.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)
  • Documentation

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@AndreiGrozav
library.mk: Fix second run for dependent lib
a974af6 
Starting from when thread building was added, the libraries are only
building once After the target file is created it does not go further with
checking dates.

This change forces the make through a phony target to properly
evaluate.

Signed-off-by: AndreiGrozav <andrei.grozav@analog.com>
@AndreiGrozav AndreiGrozav requested a review from podgori March 24, 2025 16:34
podgori
podgori approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@podgori podgori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The dependent libraries are rebuilt.
Recreated the failing scenario and tested on ad9081_fmca_ebz and adrv9009zu11eg.

@AndreiGrozav AndreiGrozav merged commit a40f5a0 into main Mar 31, 2025
3 of 5 checks passed
@AndreiGrozav AndreiGrozav deleted the fix_lib_make branch March 31, 2025 06:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@podgori podgori podgori approved these changes

@acostina acostina Awaiting requested review from acostina acostina is a code owner

@PopPaul2021 PopPaul2021 Awaiting requested review from PopPaul2021 PopPaul2021 is a code owner

@gastmaier gastmaier Awaiting requested review from gastmaier gastmaier is a code owner

@sarpadi sarpadi Awaiting requested review from sarpadi sarpadi is a code owner

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreiGrozav @podgori