Skip to content

Commit

Permalink
cataloger: implement the yarn.lock parser
Browse files Browse the repository at this point in the history
Signed-off-by: Alfredo Deza <adeza@anchore.com>
  • Loading branch information
Alfredo Deza committed Jul 28, 2020
1 parent 146b4bd commit 67fb132
Show file tree
Hide file tree
Showing 2 changed files with 77 additions and 1 deletion.
3 changes: 2 additions & 1 deletion syft/cataloger/javascript/cataloger.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package npm
package javascript

import (
"github.com/anchore/stereoscope/pkg/file"
Expand All @@ -14,6 +14,7 @@ type Cataloger struct {
func NewCataloger() *Cataloger {
globParsers := map[string]common.ParserFn{
"**/package-lock.json": parsePackageLock,
"**/yarn.lock": parseYarnLock,
}

return &Cataloger{
Expand Down
75 changes: 75 additions & 0 deletions syft/cataloger/javascript/parse_yarn_lock.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
package javascript

import (
"bufio"
"fmt"
"io"
"regexp"
"strings"

"github.com/anchore/syft/internal/log"
"github.com/anchore/syft/syft/pkg"
)

var composedNameExp = regexp.MustCompile("^\"(@{1}[^@]+)")
var simpleNameExp = regexp.MustCompile(`^[a-zA-Z\-]+@`)
var versionExp = regexp.MustCompile(`^\W+(version)\W+`)

func parseYarnLock(_ string, reader io.Reader) ([]pkg.Package, error) {
packages := make([]pkg.Package, 0)
fields := make(map[string]string)
var currentName string

scanner := bufio.NewScanner(reader)

for scanner.Scan() {
line := scanner.Text()
line = strings.TrimRight(line, "\n")

// create the entry so that the loop can keep appending versions later
_, ok := fields[currentName]
if !ok {
fields[currentName] = ""
}

switch {
case composedNameExp.MatchString(line):
name := composedNameExp.FindString(line)
if len(name) == 0 {
log.Errorf("unable to parse line: '%s'", line)
}
currentName = strings.TrimLeft(name, "\"")
case simpleNameExp.MatchString(line):
parts := strings.Split(line, "@")
currentName = parts[0]
case versionExp.MatchString(line):
parts := strings.Split(line, " \"")
version := parts[len(parts)-1]

versions, ok := fields[currentName]
if !ok {
return nil, fmt.Errorf("no previous key exists, expecting: %s", currentName)
}

if strings.Contains(versions, version) {
// already exists from another dependency declaration
continue
}

// append the version as a string so that we can check on it later
fields[currentName] = versions + " " + version
packages = append(packages, pkg.Package{
Name: currentName,
Version: strings.Trim(version, "\""),
Language: pkg.JavaScript,
Type: pkg.YarnPkg,
})
}
}

if err := scanner.Err(); err != nil {
return nil, fmt.Errorf("failed to parse yarn.lock file: %w", err)
}

return packages, nil
}

0 comments on commit 67fb132

Please # to comment.