Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Export UI handlers for reuse in other tools #113

Merged
merged 2 commits into from
Jul 30, 2020

Conversation

wagoodman
Copy link
Contributor

@wagoodman wagoodman commented Jul 30, 2020

This allows other toolbox tools to selectively re-use UI elements and incorporate in other ETUIs in the form of a single Handler object. Grype will be using these to display common elements.

@wagoodman wagoodman requested review from alfredodeza and luhring July 30, 2020 18:33
Copy link
Contributor

@alfredodeza alfredodeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure how this is all working, but seems great to be able to share across apps

@wagoodman
Copy link
Contributor Author

I'll open up a PR shortly that shows it in action, but essentially it's moving the packages releated to handling specific UI events to a single "Handler" object https://github.com/anchore/syft/pull/113/files#diff-12d657a64bc373ae734f4f3614eb6414 which can be used in grype.

@wagoodman
Copy link
Contributor Author

FYI, I bumped jotframe to pull the fix for the behavior that @rossturk was seeing earlier (cursor race conditions at frame close before showing the report, which leads to sometimes overwriting the last status line with the report)

@wagoodman wagoodman merged commit 271ba35 into master Jul 30, 2020
@wagoodman wagoodman deleted the export-select-ui-elements branch July 30, 2020 19:17
@wagoodman wagoodman modified the milestone: v0.1.0 Jul 31, 2020
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
* export UI handlers for reuse in other tools

* bump jotframe to fix cursor issues at frame close
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants