Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: add shared dir for easier cleanup #1676

Merged
merged 1 commit into from
Mar 16, 2023
Merged

fix: add shared dir for easier cleanup #1676

merged 1 commit into from
Mar 16, 2023

Conversation

spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Mar 16, 2023

Update directory construction for test to reduce potential flake

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch
goos: linux
goarch: amd64
pkg: github.com/anchore/syft/test/integration
cpu: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
                                                          │ ./.tmp/benchmark-8fdd475.txt │
                                                          │            sec/op            │
ImagePackageCatalogers/alpmdb-cataloger-2                                   11.92m ± 17%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                             802.6µ ±  1%
ImagePackageCatalogers/python-package-cataloger-2                           2.997m ±  1%
ImagePackageCatalogers/php-composer-installed-cataloger-2                   646.5µ ±  1%
ImagePackageCatalogers/javascript-package-cataloger-2                       337.1µ ±  1%
ImagePackageCatalogers/dpkgdb-cataloger-2                                   467.3µ ±  1%
ImagePackageCatalogers/rpm-db-cataloger-2                                   438.3µ ±  2%
ImagePackageCatalogers/java-cataloger-2                                     10.68m ±  1%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                     7.958µ ±  2%
ImagePackageCatalogers/apkdb-cataloger-2                                    509.9µ ±  3%
ImagePackageCatalogers/go-module-binary-cataloger-2                         18.01µ ±  1%
ImagePackageCatalogers/dotnet-deps-cataloger-2                              945.1µ ±  1%
ImagePackageCatalogers/portage-cataloger-2                                  281.6µ ±  1%
ImagePackageCatalogers/sbom-cataloger-2                                     103.2µ ±  1%
ImagePackageCatalogers/binary-cataloger-2                                   187.3µ ±  2%
geomean                                                                     444.0µ

                                                          │ ./.tmp/benchmark-8fdd475.txt │
                                                          │             B/op             │
ImagePackageCatalogers/alpmdb-cataloger-2                                   5.061Mi ± 0%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                             124.0Ki ± 0%
ImagePackageCatalogers/python-package-cataloger-2                           947.5Ki ± 0%
ImagePackageCatalogers/php-composer-installed-cataloger-2                   156.1Ki ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2                       91.17Ki ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2                                   144.7Ki ± 0%
ImagePackageCatalogers/rpm-db-cataloger-2                                   170.8Ki ± 0%
ImagePackageCatalogers/java-cataloger-2                                     2.722Mi ± 0%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                     1.555Ki ± 0%
ImagePackageCatalogers/apkdb-cataloger-2                                    129.3Ki ± 0%
ImagePackageCatalogers/go-module-binary-cataloger-2                         3.133Ki ± 0%
ImagePackageCatalogers/dotnet-deps-cataloger-2                              314.1Ki ± 0%
ImagePackageCatalogers/portage-cataloger-2                                  75.54Ki ± 0%
ImagePackageCatalogers/sbom-cataloger-2                                     13.09Ki ± 0%
ImagePackageCatalogers/binary-cataloger-2                                   29.07Ki ± 0%
geomean                                                                     108.5Ki

                                                          │ ./.tmp/benchmark-8fdd475.txt │
                                                          │          allocs/op           │
ImagePackageCatalogers/alpmdb-cataloger-2                                    86.71k ± 0%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                              2.049k ± 0%
ImagePackageCatalogers/python-package-cataloger-2                            15.48k ± 0%
ImagePackageCatalogers/php-composer-installed-cataloger-2                    3.458k ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2                        1.214k ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2                                    2.646k ± 0%
ImagePackageCatalogers/rpm-db-cataloger-2                                    3.759k ± 0%
ImagePackageCatalogers/java-cataloger-2                                      38.26k ± 0%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                       40.00 ± 0%
ImagePackageCatalogers/apkdb-cataloger-2                                     3.438k ± 0%
ImagePackageCatalogers/go-module-binary-cataloger-2                           101.0 ± 0%
ImagePackageCatalogers/dotnet-deps-cataloger-2                               5.010k ± 0%
ImagePackageCatalogers/portage-cataloger-2                                   1.487k ± 0%
ImagePackageCatalogers/sbom-cataloger-2                                       392.0 ± 0%
ImagePackageCatalogers/binary-cataloger-2                                     872.0 ± 0%
geomean                                                                      2.219k

@spiffcs spiffcs merged commit 928c4a5 into main Mar 16, 2023
@spiffcs spiffcs deleted the cli-validation-tests branch March 16, 2023 20:05
spiffcs added a commit to deitch/syft that referenced this pull request Mar 21, 2023
* main: (47 commits)
  Deprecate config.yaml as valid config source; Add unit regression for correct config paths (anchore#1640)
  chore: Update syft bootstrap tools to latest versions. (anchore#1682)
  Update documentation: (anchore#1680)
  chore: Update Stereoscope to 7928713c391e20abaede6a029f4ce37b628a4c8b (anchore#1681)
  fix: reduce logging for bad dpkg lines (anchore#1675)
  fix ruby classifier (anchore#1678)
  feat: add shared dir for easier cleanup (anchore#1676)
  chore(deps): bump github.com/google/go-containerregistry (anchore#1672)
  chore(deps): bump actions/setup-go from 3 to 4 (anchore#1671)
  fix: move defer after error to protect panic case (anchore#1670)
  feat: add argocd, helm, kustomize and kubectl binary classifiers (anchore#1663)
  defer closing file (anchore#1668)
  fix: remove author contributing to javascript CPEs (anchore#1669)
  fix: more python matching support (anchore#1667)
  Update syft bootstrap tools to latest versions. (anchore#1666)
  feat: add ruby classifier (anchore#1665)
  Update syft bootstrap tools to latest versions. (anchore#1658)
  fix: improved Python binary detection (anchore#1648)
  fix: suppress some known incorrect vendor candidates for npm CPEs (anchore#1659)
  fix: sanitize SPDX LicenseRefs (anchore#1657)
  ...

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@spiffcs spiffcs changed the title feat: add shared dir for easier cleanup fix: add shared dir for easier cleanup Mar 31, 2023
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants