Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add scope to pom properties #1779

Merged
merged 2 commits into from
Jun 1, 2023
Merged

feat: add scope to pom properties #1779

merged 2 commits into from
Jun 1, 2023

Conversation

jneate
Copy link
Contributor

@jneate jneate commented May 4, 2023

This lays the foundation for anchore/grype#985

@kzantow
Copy link
Contributor

kzantow commented May 4, 2023

Thanks @jneate -- one thing, since you've modified the metadata, you'll need to bump the schema version (just a patch bump seems fine here) and regenerate the new schema. Info can be found here: https://github.com/anchore/syft/blob/main/schema/json/README.md. Essentially, It should just be update here: https://github.com/anchore/syft/blob/main/internal/constants.go#L9 and then run cd schema/json && go run generate.go

@jneate
Copy link
Contributor Author

jneate commented May 4, 2023

Let me rebase, looks like someone bumped the schema before me

jneate added 2 commits May 29, 2023 00:10
Signed-off-by: James Neate <jamesmneate@gmail.com>
Signed-off-by: James Neate <jamesmneate@gmail.com>
@wagoodman wagoodman enabled auto-merge (squash) June 1, 2023 12:15
@wagoodman wagoodman merged commit c69cdd9 into anchore:main Jun 1, 2023
spiffcs added a commit that referenced this pull request Jun 5, 2023
* main: (21 commits)
  chore(deps): bump github.com/sirupsen/logrus from 1.9.2 to 1.9.3 (#1862)
  chore(deps): bump modernc.org/sqlite from 1.22.1 to 1.23.0 (#1863)
  feat: source-version flag (#1859)
  chore(deps): bump github.com/spf13/viper from 1.15.0 to 1.16.0 (#1851)
  accept main.version ldflags even without vcs (#1855)
  feat: add scope to pom properties (#1779)
  chore(deps): bump github.com/stretchr/testify from 1.8.3 to 1.8.4 (#1852)
  chore(deps): bump github.com/docker/docker (#1849)
  Add test to ensure package metadata is represented in the JSON schema (#1841)
  Fix directory resolver to consider CWD and root path input correctly (#1840)
  Migrate location-related structs to the file package (#1751)
  chore(deps): bump github.com/go-git/go-git/v5 from 5.6.1 to 5.7.0 (#1843)
  fix: add panic recovery for license parse (#1839)
  chore: return both failures when failed to retrieve an image with a scheme (#1801)
  Extract go module versions from ldflags for binaries built by go (#1832)
  fix: duplicate packages, support pnpm lockfile v6 (#1778)
  chore(deps): update stereoscope to e14bc4437b2eac481c5b6f101890b22df4f33596 (#1834)
  chore(deps): bump github.com/stretchr/testify from 1.8.2 to 1.8.3 (#1829)
  chore(deps): bump github.com/docker/docker (#1833)
  Keep original FileInfo persisted on file.Metadata structs (#1794)
  ...

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@spiffcs spiffcs added the enhancement New feature or request label Jun 5, 2023
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
* feat: add scope to pom properties

Signed-off-by: James Neate <jamesmneate@gmail.com>

* fix: fixed conflict with schema bump

Signed-off-by: James Neate <jamesmneate@gmail.com>

---------

Signed-off-by: James Neate <jamesmneate@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants