Resolve security warning for macOS users #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Luhring <dan.luhring@anchore.com>
wagoodman
reviewed
Nov 4, 2020
Makefile
Outdated
| @@ -241,8 +244,7 @@ changelog-release: | |||
|
|
|||
| .PHONY: changelog-unreleased | |||
| changelog-unreleased: ## show the current changelog that will be produced on the next release (note: requires GITHUB_TOKEN set) | |||
| @docker run -it --rm \ | |||
| -v "$(shell pwd)":/usr/local/src/your-app ferrarimarco/github-changelog-generator \ | |||
| @github_changelog_generator \ | |||
There was a problem hiding this comment.
the changelog-unreleased is a target meant for local developers to be able to (optionally) use to see what the changelog would be before cutting a release. By leveraging the docker image dev's don't need to install the right version of ruby, install the gem, and get pathing correct. With the new change that would be required.
(The changelog-release target is OK, since this env is setup with ci-bootstrap-mac)
There was a problem hiding this comment.
Sounds good, reverting this.
Signed-off-by: Dan Luhring <dan.luhring@anchore.com>
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
* Add support for macOS signing and notarization Signed-off-by: Dan Luhring <dan.luhring@anchore.com> * Use Docker to run the changelog generator locally Signed-off-by: Dan Luhring <dan.luhring@anchore.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.tar.gzasset with a.dmgassetThis implements https://github.com/anchore/project-toolbox/issues/27 for syft. Other released executables will need similar changes.