fix: Better test for group ID in filename #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where filenames containing a period that aren't a group ID, such as some-jar.12.jar, would be mistakenly be reported as having the name "12" by syft, instead of the name "some-jar.12". Signed-off-by: Will Murphy <will.murphy@anchore.com>
spiffcs
approved these changes
Jan 30, 2024
Signed-off-by: Will Murphy <will.murphy@anchore.com>
|
Oh does this also fix #2385? Seems like it probably does. I can give it a check later |
|
@westonsteimel it looks like this fixes the artifact ID but not the group ID for #2385: I think it's still worth getting in, and we can try to figure out the group ID issue in another PR. I'll push a unit test that prevents regression on that particular kafka jar's artifact ID. |
Signed-off-by: Will Murphy <will.murphy@anchore.com>
|
Yeah, I didn't bother updating the groupid mapping for those since the name was too broken before. Thanks for figuring the name bit out! |
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
This fixes an issue where filenames containing a period that aren't a group ID, such as some-jar.12.jar, would be mistakenly be reported as having the name "12" by syft, instead of the name "some-jar.12". It works by testing whether the parts of the filename split on "." are all valid Java identifiers. Signed-off-by: Will Murphy <will.murphy@anchore.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where filenames containing a period that aren't a group ID, such as some-jar.12.jar, would be mistakenly be reported as having the name "12" by syft, instead of the name "some-jar.12".
Fixes #2563.