fix(dotnet): prefer portable executable product version when semantically greater than file version #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonsteimel
force-pushed
the
nuget-package-version-improvement
branch
3 times, most recently
from
6354337 to
ec16ad2
Compare
…ally greater than file version Signed-off-by: Weston Steimel <weston.steimel@anchore.com>
westonsteimel
force-pushed
the
nuget-package-version-improvement
branch
from
ec16ad2 to
f3a05a0
Compare
wagoodman
approved these changes
Feb 7, 2024
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
…ally greater than file version (anchore#2600) Signed-off-by: Weston Steimel <weston.steimel@anchore.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When choosing the main version for a portable executable, always prefer the product version when it is semantically greater than the file version. The file version can remain the same across multiple releases of a nuget package, but the product version increments.