feat: index known CPEs for go modules #2816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weston Steimel <commits@weston.slmail.me>
westonsteimel
force-pushed
the
index-known-go-module-cpes
branch
from
7549ccf to
7c34ff9
Compare
spiffcs
reviewed
Apr 26, 2024
|
|
||
| func addEntryForGoModulePackage(indexed *dictionary.Indexed, ref string, cpeItemName string) { | ||
| // Prune off the non-package-name parts of the URL | ||
| ref = strings.Split(ref, "?")[0] |
There was a problem hiding this comment.
Is ref here always a valid URL?
If it is and we're trying to split off the Query parameters is it safer to do something like the following?
u, err := url.Parse(ref)
if err != nil {
// handle error and resort to split method
}
ref = u.Scheme + "://" + u.Host + u.Path
There was a problem hiding this comment.
This was taken from how this is done in the functions for the other ecosystems
There was a problem hiding this comment.
I'm sure there is potential for refactoring this entire CPE index building element, but I probably do not have the capacity for that currently
spiffcs
approved these changes
Apr 26, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.