chore: use ruleguard to test for missing defer statements

[willmurphyscode]

See #2826

Supersedes #2836.

The only hang-up I've seen is that calls to make lint can run an old version of the rules unless ./.tool/golangci-lint cache clean is called first, which could be annoying when PRing future rule changes.

[willmurphyscode]

We see that this branch has the expected failures: https://github.com/anchore/syft/actions/runs/8930279182/job/24530010619?pr=2837#step:4:50

task: [lint] .tool/golangci-lint run --tests=false
Error: syft/linux/identify_release.go:67:4: ruleguard: internal.CloseAndLogError should be deferred right after the error returned from resolver.FileContentsByLocation is checked. (gocritic)
			contentReader, err := resolver.FileContentsByLocation(location)
			^
... snip many more ...
task: Failed to run task "static-analysis": exit status 1

Taking a look at syft/linux/identify_release.go:67:4, we see:

syft/syft/linux/identify_release.go

Lines 66 to 90 in 9eb8c62

	for _, location := range locations {
	contentReader, err := resolver.FileContentsByLocation(location)
	if err != nil {
	logger.WithFields("error", err, "path", location.RealPath).Trace("unable to get contents")
	continue
	}
	content, err := io.ReadAll(contentReader)
	internal.CloseAndLogError(contentReader, location.AccessPath)
	if err != nil {
	logger.WithFields("error", err, "path", location.RealPath).Trace("unable to read contents")
	continue
	}
	release, err := entry.fn(string(content))
	if err != nil {
	logger.WithFields("error", err, "path", location.RealPath).Trace("unable to parse contents")
	continue
	}
	if release != nil {
	return release
	}
	}
	}

clearly has the issue

[wagoodman]

slick!

[spiffcs]

Approved - Small comment on moving a wrap directive to string for an error value =)

[spiffcs]

Are we changing the error from %w to %s here?