Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: update mainModuleVersion function to always prefix v to findings #3087

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Jul 31, 2024

Summary

Fixes #3086

For a summary on what happened and the regression this fixes see this comment:
#3086 (comment)

spiffcs added 2 commits July 31, 2024 14:30
Signed-off-by: Christopher Phillips <32073428+spiffcs@users.noreply.github.com>
Signed-off-by: Christopher Phillips <32073428+spiffcs@users.noreply.github.com>
@spiffcs spiffcs force-pushed the 3086-go-binary-version branch from deac7f2 to a9fdd3c Compare July 31, 2024 19:04
@spiffcs spiffcs marked this pull request as ready for review July 31, 2024 19:04
@spiffcs spiffcs self-assigned this Jul 31, 2024
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spiffcs spiffcs merged commit c84cb2c into main Aug 1, 2024
11 checks passed
@spiffcs spiffcs deleted the 3086-go-binary-version branch August 1, 2024 15:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Version parsing regression for Go binaries
2 participants