Add compliance policy for empty name and version #3257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
|
One observation: once the known-unknowns lands perhaps some of these options would go away / change? E.g. a user could surface something in the files section with something like: |
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
|
I think the config placement and package organization is correct here from and API standpoint so 🟢 from me. Was there any other discussion you wanted @wagoodman on this PR? |
spiffcs
approved these changes
Sep 20, 2024
luhring
added a commit
to wolfi-dev/wolfictl
that referenced
this pull request
Sep 25, 2024
Looks like just "UNKNOWN" being added to existing packages, likely from anchore/syft#3257. Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
spiffcs
added a commit
that referenced
this pull request
Oct 2, 2024
* main: (343 commits) feat: update haproxy classifier (#3277) chore(deps): update tools to latest versions (#3291) fix: don't use builtin scanner in licensecheck (#3290) chore(deps): update CPE dictionary index (#3288) chore(deps): bump github/codeql-action from 3.26.9 to 3.26.10 (#3289) update redis classifier (#3281) fix: improve node classifier version matching (#3284) fix: update ruby classifier for -rc, -dev, etc. versions (#3285) chore(deps): update CPE dictionary index (#3262) chore(deps): bump github.com/docker/docker (#3264) chore(deps): bump github/codeql-action from 3.26.8 to 3.26.9 (#3275) chore(deps): update stereoscope to dc10ea61fd18efa45b516eda4de8bc19d8322429 (#3280) chore(deps): bump actions/checkout from 4.1.7 to 4.2.0 (#3283) add awaiting response management (#3272) fix: correct excluded mount point comparison to file paths (#3269) Add JVM cataloger (#3217) feat: classifier for Dart lang binaries (#3265) Add compliance policy for empty name and version (#3257) chore(deps): bump github.com/github/go-spdx/v2 from 2.3.1 to 2.3.2 (#3254) chore(deps): bump peter-evans/create-pull-request from 7.0.3 to 7.0.5 (#3255) ...
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new compliance configuration to handle what to do when there is a missing name or version:
Above are the default values, but the possible values a user can put in are:
keep, add a trace log but the non-compliant package is still added to the SBOMdrop, exclude the package from results, add a debug logstub, replace the non-compliant empty value withUNKNOWNOpen questions:
pkgcatalogingpackage? (instead of thecatalogingpackage?)Closes #2132
Closes #2652
Closes #2038
Closes #2039