Fix: Parse package.json with non-standard fields in 'author' section

[nuada]

Several npm packages, including those within the AWS CDK ecosystem, use non-standard fields within their package.json files (e.g., "organization": true). This caused parsing errors and excluded these packages from reports.

This fix modifies the JavaScript package cataloger to correctly handle these non-standard fields, ensuring accurate parsing and inclusion of all packages in the report.

aws-cdk/package.json:

...
"author": {
  "name": "Amazon Web Services",
  "url": "https://aws.amazon.com",
  "organization": true
},
...

Scan example before fix:

syft scan XXX
 ✔ Parsed image sha256:XXX
 ✔ Cataloged contents XXX
   ├── ✔ Packages                        [1,519 packages]
   ├── ✔ File digests                    [32,435 files]
   ├── ✔ File metadata                   [32,435 locations]
   └── ✔ Executables                     [2,057 executables]
[0036]  WARN cataloger failed cataloger=javascript-package-cataloger error=failed to parse package.json file: unable to parse package.json author: json: cannot unmarshal bool into Go value of type string location=/usr/local/lib/node_modules/aws-cdk-lib/node_modules/@aws-cdk/asset-awscli-v1/package.json
[0036]  WARN cataloger failed cataloger=javascript-package-cataloger error=failed to parse package.json file: unable to parse package.json author: json: cannot unmarshal bool into Go value of type string location=/usr/local/lib/node_modules/aws-cdk-lib/node_modules/@aws-cdk/asset-kubectl-v20/package.json
[0036]  WARN cataloger failed cataloger=javascript-package-cataloger error=failed to parse package.json file: unable to parse package.json author: json: cannot unmarshal bool into Go value of type string location=/usr/local/lib/node_modules/aws-cdk-lib/node_modules/@aws-cdk/asset-node-proxy-agent-v6/package.json
[0036]  WARN cataloger failed cataloger=javascript-package-cataloger error=failed to parse package.json file: unable to parse package.json author: json: cannot unmarshal bool into Go value of type string location=/usr/local/lib/node_modules/aws-cdk-lib/node_modules/@aws-cdk/cloud-assembly-schema/package.json
[0036]  WARN cataloger failed cataloger=javascript-package-cataloger error=failed to parse package.json file: unable to parse package.json author: json: cannot unmarshal bool into Go value of type string location=/usr/local/lib/node_modules/aws-cdk-lib/node_modules/constructs/package.json
[0036]  WARN cataloger failed cataloger=javascript-package-cataloger error=failed to parse package.json file: unable to parse package.json author: json: cannot unmarshal bool into Go value of type string location=/usr/local/lib/node_modules/aws-cdk-lib/package.json
[0036]  WARN cataloger failed cataloger=javascript-package-cataloger error=failed to parse package.json file: unable to parse package.json author: json: cannot unmarshal bool into Go value of type string location=/usr/local/lib/node_modules/aws-cdk/package.json
[0036]  WARN cataloger failed cataloger=javascript-package-cataloger error=failed to parse package.json file: unable to parse package.json author: json: cannot unmarshal bool into Go value of type string location=/usr/local/lib/node_modules/cdk-nag/node_modules/@aws-cdk/asset-awscli-v1/package.json
[0036]  WARN cataloger failed cataloger=javascript-package-cataloger error=failed to parse package.json file: unable to parse package.json author: json: cannot unmarshal bool into Go value of type string location=/usr/local/lib/node_modules/cdk-nag/node_modules/@aws-cdk/asset-kubectl-v20/package.json
[0036]  WARN cataloger failed cataloger=javascript-package-cataloger error=failed to parse package.json file: unable to parse package.json author: json: cannot unmarshal bool into Go value of type string location=/usr/local/lib/node_modules/cdk-nag/node_modules/@aws-cdk/asset-node-proxy-agent-v6/package.json
[0036]  WARN cataloger failed cataloger=javascript-package-cataloger error=failed to parse package.json file: unable to parse package.json author: json: cannot unmarshal bool into Go value of type string location=/usr/local/lib/node_modules/cdk-nag/node_modules/@aws-cdk/cloud-assembly-schema/package.json
[0036]  WARN cataloger failed cataloger=javascript-package-cataloger error=failed to parse package.json file: unable to parse package.json author: json: cannot unmarshal bool into Go value of type string location=/usr/local/lib/node_modules/cdk-nag/node_modules/aws-cdk-lib/package.json
[0036]  WARN cataloger failed cataloger=javascript-package-cataloger error=failed to parse package.json file: unable to parse package.json author: json: cannot unmarshal bool into Go value of type string location=/usr/local/lib/node_modules/cdk-nag/node_modules/constructs/package.json
[0036]  WARN cataloger failed cataloger=javascript-package-cataloger error=failed to parse package.json file: unable to parse package.json author: json: cannot unmarshal bool into Go value of type string location=/usr/local/lib/node_modules/cdk-nag/package.json

[willmurphyscode]

Hi @nuada,

Thanks very much for this fix! We really appreciate it.

Would you mind making 2 changes?

1. Can you add a unit test that covers the new behavior?
2. Please commit with sign-off (git commit -s) for all commits on the branch. You can see more about DCO here. You'll have to re-create / amend the existing commit.

[nuada]

Hi @willmurphyscode,

Happy to help! DCO fixed.

How about such a test?

[willmurphyscode]

Looks great. Thanks @nuada!