fix: improve go binary semver extraction for traefik #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the go cataloger semver extraction logic to include getting the release version of traefik. This is based off of the regex pattern that already existed in the traefik binary classifier. Signed-off-by: Weston Steimel <commits@weston.slmail.me>
westonsteimel
force-pushed
the
improve-go-binary-semver-file-string-extraction
branch
from
7f31887 to
14c0fe7
Compare
wagoodman
approved these changes
Oct 14, 2024
westonsteimel
deleted the
improve-go-binary-semver-file-string-extraction
branch
HeyeOpenSource
pushed a commit
to HeyeOpenSource/syft
that referenced
this pull request
Oct 14, 2024
Improves the go cataloger semver extraction logic to include getting the release version of traefik. This is based off of the regex pattern that already existed in the traefik binary classifier. Signed-off-by: Weston Steimel <commits@weston.slmail.me> Signed-off-by: HeyeOpenSource <opensource@heye-international.com>
HeyeOpenSource
pushed a commit
to HeyeOpenSource/syft
that referenced
this pull request
Oct 14, 2024
Improves the go cataloger semver extraction logic to include getting the release version of traefik. This is based off of the regex pattern that already existed in the traefik binary classifier. Signed-off-by: Weston Steimel <commits@weston.slmail.me> Signed-off-by: HeyeOpenSource <opensource@heye-international.com>
HeyeOpenSource
pushed a commit
to HeyeOpenSource/syft
that referenced
this pull request
Oct 15, 2024
Improves the go cataloger semver extraction logic to include getting the release version of traefik. This is based off of the regex pattern that already existed in the traefik binary classifier. Signed-off-by: Weston Steimel <commits@weston.slmail.me> Signed-off-by: HeyeOpenSource <opensource@heye-international.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances the go cataloger semver extraction logic to include getting the release version of traefik. This is based off of the regex pattern that already existed in the traefik binary classifier.
The advantage to raising up the release version in the go cataloger rather than just in the binary classifier is that it means the vulnerability matching can take advantage of the GitHub security advisory data for traefik rather than just the NVD CVE entries. I think this would have prevented anchore/grype#2178 from occurring