Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: malformed pom.xml may cause recursive loop #3391

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix: malformed pom.xml may cause recursive loop #3391

merged 1 commit into from
Oct 28, 2024

Conversation

kzantow
Copy link
Contributor

@kzantow kzantow commented Oct 28, 2024 •
edited
Loading

Description

This PR corrects a case where certain malformed pom.xml files could cause an infinite loop.

This was reported on Discourse

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added unit tests that cover changed behavior
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections

@kzantow kzantow added the bug Something isn't working label Oct 28, 2024
@kzantow
fix: malformed pom files cause infinite loop
1218615 
Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow kzantow force-pushed the fix/java-pom-property-resolution-cycle branch from b57436e to 1218615 Compare October 28, 2024 21:15
@kzantow kzantow changed the title chore: address PR feedback fix: malformed pom.xml may cause recursive loop Oct 28, 2024
@kzantow kzantow merged commit 1118ac4 into anchore:main Oct 28, 2024
12 checks passed
@kzantow kzantow deleted the fix/java-pom-property-resolution-cycle branch October 28, 2024 22:09
@BrewTestBot BrewTestBot mentioned this pull request Nov 5, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wagoodman wagoodman wagoodman approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kzantow @wagoodman