feat: emit dependency relationships found in Cargo.lock #3443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include updating test dependency to have dependencies on multiple versions of the same crate. Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
willmurphyscode
commented
Nov 14, 2024
I haven't actually seen the other two types of keys in the wild. Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
wagoodman
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
nice!
Just an fyi, there is a dependency.Specifier and processor for these kinds of things (see the dpkg dependency and its usage as a cataloger post-processor.
The one difference with that specific approach and here is that we'd want to still keep dependencies from the single cargo.lock related (and not related to seemingly overlapping dependencies in other cargo.lock files), which means it's use as a post-processor across all packages found by the cataloger wouldn't be correct, but it could be used within the cataloger instead as a post-processor, thus reusing the abstraction.
No need to change this code on the PR, but could be helpful for future PRs like this one.
willmurphyscode
commented
Nov 14, 2024
Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include updating test dependency to have dependencies on multiple versions of the same crate.
Description
Partially implements #572 by adding support for emitting dependency relationships between crates as enumerated in Cargo.lock files.
Fixes #2353.
Type of change
This is a new feature.
Checklist: