fix: stop omitting redundantly parenthesized licenses in CDX formatter #3517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there might still be issues with the generated expressions. Back to draft for now. |
Previously, a bug in the formatter would cause SPDX expressions that were surrounded in redundant parentheses to be dropped instead of normalized. Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
willmurphyscode
force-pushed
the
fix-redundant-parens-in-spdx-license
branch
from
d2e29bd to
092c374
Compare
willmurphyscode
commented
Dec 11, 2024
| @@ -20,6 +20,11 @@ func TestParseExpression(t *testing.T) { | |||
| expression: "MIT OR Apache-2.0", | |||
| want: "MIT OR Apache-2.0", | |||
| }, | |||
| { | |||
| name: "accept redundant parentheses", | |||
There was a problem hiding this comment.
This test case was never failing on main, but it was the first place I looked, so adding it seems worthwhile to me.
wagoodman
approved these changes
Dec 11, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a bug in the formatter would cause SPDX expressions that were surrounded in redundant parentheses to be dropped instead of normalized.
Description
Type of change
Checklist: