Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: server tests #33

Merged
merged 1 commit into from
Aug 25, 2021
Merged

fix: server tests #33

merged 1 commit into from
Aug 25, 2021

Conversation

kartikp36
Copy link
Member

No description provided.

@kartikp36 kartikp36 requested a review from harsilspatel August 3, 2021 10:26
harsilspatel
harsilspatel requested changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@harsilspatel harsilspatel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your local tests work because note is added and removed from the actual db. And GitHub doesn't run the jest test, it's only linting

Leave this for now and work on something else

@kartikp36
Copy link
Member Author

@harsilspatel This needs to be merged now, CI action setup is completed in #36

@kartikp36 kartikp36 merged commit 0e5e672 into main Aug 25, 2021
@kartikp36 kartikp36 deleted the KB-139-fix-server-test branch August 25, 2021 16:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@harsilspatel harsilspatel harsilspatel requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kartikp36 @harsilspatel