Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adds uiFormDelete() #141

Merged
merged 3 commits into from
Jun 15, 2016
Merged

Adds uiFormDelete() #141

merged 3 commits into from
Jun 15, 2016

Conversation

emersion
Copy link
Contributor

@emersion emersion commented Jun 14, 2016 •
edited
Loading

See #135

@andlabs
Copy link
Owner

andlabs commented Jun 14, 2016

If you take a closer look, you'll see that the OS X implementation of -[formView delete:] doesn't exist

@emersion
Copy link
Contributor Author

Well, that's the only platform on which I didn't tests because I haven't any OS X device :(

@emersion
Copy link
Contributor Author

Okay, just tried to add -[formView delete:]. No idea if it works though.

@emersion
Copy link
Contributor Author

Just updated darwin. I pulled changes you made yesterday on master and tested it on a real macOS device.

@andlabs
Copy link
Owner

andlabs commented Jun 15, 2016

Cool, thanks. I'll read through this again in a bit and merge it (making fixes as necessary; again, very subtle stuff). Good work!

@andlabs andlabs merged commit ac1a515 into andlabs:master Jun 15, 2016
@emersion emersion deleted the ui-form-delete branch June 17, 2016 09:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emersion @andlabs