Skip to content

Set appropriate colours for Multiline Entry control on dark mode (Darwin) #481

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

TropicalBastos
Copy link

The PR checks in the following:

  • White font colour for multi line entry if user has dark mode enabled
  • Dark background colour for multi line entry if user has dark mode enabled
  • Utility method for checking if dark mode is enabled
  • .gitignore entry for ignoring the build folder

@TropicalBastos
Copy link
Author

TropicalBastos commented Jan 12, 2020

Only just noticed that there has been a previous PR for this particular dark mode issue. However, it looks like the previous one did not pass all tests.

@LoganDark
Copy link

LoganDark commented Aug 25, 2020

isDarkMode should be either be uiprivIsDarkMode and inside of uipriv_darwin.h, or uiDarwinIsDarkMode and inside of ui_darwin.h (honestly, the latter would be more useful because then people can use it in their libui apps). In both cases it should probably be defined in main.m (or a more specific file) and not a util.m

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants