Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Last Workable RTL patch (need little work) #6

Closed
wants to merge 5 commits into from

Conversation

moceap
Copy link

@moceap moceap commented Jun 23, 2015

No description provided.

@luzpaz
Copy link
Collaborator

luzpaz commented Jun 25, 2015

Thanks @moceap !
When you say: "Last Workable RTL patch" can you explain what you mean exactly?

@moceap
Copy link
Author

moceap commented Jun 26, 2015

There is a many tries to support Arabic (and other RTLs) in Scribus, and this is the last (most developed) patch.

https://build.opensuse.org/package/show/home:moceap/Scribus

And I improve it to be included in trunk , and it need work to :

  • Fix some building issues.
  • Extract (fribidi - harfbuz) out of it.

@luzpaz @andreas-vox

@luzpaz
Copy link
Collaborator

luzpaz commented Jun 26, 2015

@moceap looks like the patches have harfbuzz and fribidi in them. So perhaps I'm misinterpreting your words
And I improve it to be included in trunk , and it need work to : Extract (fribidi - harfbuz) out of it.
Are you planning on refining the patches ?

@moceap
Copy link
Author

moceap commented Jun 26, 2015

I mean the (fribidi , harfbuzz) included in the patch, the patch must improved to depend on external libs (fribidi ....) to keep them updated. :) just this..

Anyway I think we must fix building issues first ... Now I don't have enough time for that .. I hope if one of you doing that ..

@luzpaz @andreas-vox

@luzpaz
Copy link
Collaborator

luzpaz commented Jun 28, 2015

CC @aoloe @FirasH @sarathms

@priyanshs
Copy link

I'd like to help with the hindi support if possible.

@luzpaz
Copy link
Collaborator

luzpaz commented Jul 5, 2015

@NonsoN Hello! How would you like to contribute ?

@moceap
Copy link
Author

moceap commented Jul 7, 2015

First thing ... @andreas-vox accept the patch and sync to master ... then any changes from other contributors ..

@moceap
Copy link
Author

moceap commented Jul 11, 2015

@andreas-vox News?

@luzpaz
Copy link
Collaborator

luzpaz commented Jul 11, 2015

@moceap he's been busy and has planned to make some time this weekend to work on CTL.

@luzpaz
Copy link
Collaborator

luzpaz commented Jul 20, 2015

@moceap sorry I don't have the technical prowess to do this.

@andreas-vox
Copy link
Owner

I created a branch for your patch but it doesn't compile.
If you want I can commit the branch in this state, but as I see it, fixing it would go into the opposite direction to what I've planned for master.

@luzpaz
Copy link
Collaborator

luzpaz commented Jul 21, 2015

@andreas-vox can you elaborate what your plans are for master. I opened an issue for you that could help others understand your agenda for this project. That way @moceap and others that have offered to help over the past month can see where they can contribute. What do you think?

@andreas-vox
Copy link
Owner

Hi, I committed this to branch "RTL". It compiles on OS/X Yosemite; if you face problems compiling, please report or send patch.

I haven't tested its functionality thoroughly, but it appears to display correct Arabic on canvas. Editing on canvas is not possible since the cursor position is off.

I plan to keep this branch as a reference but will not merge it back into master, since the chosen approach will make it difficult to realize the other goals of CTL. More details in issue #3.

@andreas-vox andreas-vox closed this Aug 7, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants