Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change BUILD_INSIGHTS_OUTSIDE_LLVM to an option to allow customization #671

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Freed-Wu
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.83%. Comparing base (cba412f) to head (6dcd688).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #671   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files          20       20           
  Lines        6527     6527           
=======================================
  Hits         6386     6386           
  Misses        141      141           
Flag Coverage Δ
insights-macos 97.10% <ø> (ø)
insights-ubuntu-amd64-libcxx-No 98.08% <ø> (ø)
insights-ubuntu-amd64-libcxx-Yes 98.06% <ø> (ø)
insights-ubuntu-arm64-libcxx-No 98.04% <ø> (ø)
insights-ubuntu-arm64-libcxx-Yes 98.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Freed-Wu added a commit to Freed-Wu/cppinsights.nvim that referenced this pull request Sep 20, 2024
@andreasfertig
Copy link
Owner

Hello @Freed-Wu,

what is the motivation for that change? The whole point here is that one has not to say whether the build is inside the Clang source tree or not. Am I overlooking something?

Andreas

@Freed-Wu
Copy link
Contributor Author

I hope I can build the project by cmake's FetchContent(), However CMAKE_CURRENT_SOURCE_DIR != CMAKE_SOURCE_DIR set BUILD_INSIGHTS_OUTSIDE_LLVM=ON make it impossible.

@Freed-Wu
Copy link
Contributor Author

For example, https://github.com/Freed-Wu/cppinsights.nvim use git submodule to get the source code, not cmake's FetchContent().

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants