Fruittie screen and ios designs #78

mlykotom · 2025-06-26T10:27:40Z

created fruittie screen (ios+android)
added bunch of actions (increase/decrease to cart), how many fruits in cart
improved ios designs to use default components
improved android designs

Split app to 2 screens with Navigation3 and NavigationStack

Design list + cart screens

gemini-code-assist

Summary of Changes

Hello @mlykotom, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the application's user experience by introducing a new detail view for individual fruit items and improving the cart management capabilities. The changes also include a substantial UI overhaul on both Android and iOS to leverage modern platform components and design patterns.

Highlights

New Fruittie Detail Screen: Introduced a dedicated detail screen for individual 'fruitties' on both Android (Compose) and iOS (SwiftUI), allowing users to view more information about a specific item and add it to their cart.
Enhanced Cart Management: Implemented functionality to increase and decrease the quantity of items directly within the cart view on both platforms, providing a more interactive shopping experience.
UI/UX Improvements: Refactored the user interface for both Android and iOS to align with platform-specific design best practices, utilizing native components like LargeTopAppBar and List in SwiftUI, and FilledIconButton in Compose, resulting in a more polished and consistent look and feel.
Navigation Updates: Updated the navigation flow to support the new fruittie detail screen, allowing users to tap on a fruittie from the main list to view its details.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

The pull request introduces the Fruittie detail screen and improves the UI on Android and iOS. The Swift code has critical issues with calling async functions synchronously. UI consistency can be improved by using theme colors. State handling and navigation should be more robust.

Fruitties/iosApp/iosApp/ui/ContentView.swift

Fruitties/iosApp/iosApp/ui/FruittieScreen.swift

Fruitties/gradle/libs.versions.toml

Fruitties/shared/src/commonMain/kotlin/com/example/fruitties/viewmodel/FruittieViewModel.kt

Fruitties/androidApp/src/main/java/com/example/fruitties/android/MainActivity.kt

Fruitties/androidApp/src/main/java/com/example/fruitties/android/ui/CartScreen.kt

Fruitties/androidApp/src/main/java/com/example/fruitties/android/ui/FruittieScreen.kt

Fruitties/iosApp/iosApp/ui/CartView.swift

Fruitties/iosApp/iosApp/ui/FruittieScreen.swift

…igns" This reverts commit a2761d6, reversing changes made to ea1bde8.

…id/ui/CartScreen.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Fruitties/androidApp/src/main/java/com/example/fruitties/android/ui/FruittieScreen.kt

Fruitties/androidApp/src/main/java/com/example/fruitties/android/ui/ListScreen.kt

Fruitties/androidApp/src/main/java/com/example/fruitties/android/ui/CartScreen.kt

cartland

LGTM, remember to run ./gradlew spotlessApply (requested in #75)

cartland · 2025-07-02T18:52:53Z

Fruitties/androidApp/src/main/java/com/example/fruitties/android/ui/CartScreen.kt

@@ -69,6 +82,22 @@ fun CartScreen(onNavBarBack: () -> Unit) {

    val cartState by viewModel.cartUiState.collectAsState()

+    CartScreen(


Thank you for extracting the state like this. I wanted to do this.

mlykotom added 8 commits June 25, 2025 14:20

Fix gradle wrapper validation (#77)

b567e48

Merge pull request #73 from android/nav3

92a9de0

Split app to 2 screens with Navigation3 and NavigationStack

Update material3 to prevent recompositions

b9635fb

Add FruittieScreen + connect cart actions

d3abf2a

ios: Fix toolbar

0b43489

ios: design cart with +- actions

6851493

Fix typo

2e349c8

Design frutttie + list + cart screens

ea1bde8

Design list + cart screens

mlykotom requested review from bentrengrove and cartland June 26, 2025 10:27

gemini-code-assist bot reviewed Jun 26, 2025

View reviewed changes

Merge branch 'main' into mlykotom/fruittie-screen-and-ios-designs

a2761d6

gemini-code-assist bot reviewed Jun 26, 2025

View reviewed changes

mlykotom and others added 2 commits June 26, 2025 12:31

Revert "Merge branch 'main' into mlykotom/fruittie-screen-and-ios-des…

b5b9ee5

…igns" This reverts commit a2761d6, reversing changes made to ea1bde8.

Update Fruitties/androidApp/src/main/java/com/example/fruitties/andro…

a1dfdf7

…id/ui/CartScreen.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

bentrengrove approved these changes Jun 29, 2025

View reviewed changes

mlykotom added 4 commits June 30, 2025 10:35

Add previews to CartScreen

3cafda5

TotalItemCounts is calculated from state

33aa359

String res for cart has items

f802fed

Handle paddings on list screen

7b61df5

mlykotom requested review from marcellogalhardo and removed request for marcellogalhardo July 1, 2025 08:20

cartland approved these changes Jul 2, 2025

View reviewed changes

Format: Spotless

d107f53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fruittie screen and ios designs #78

Fruittie screen and ios designs #78

Uh oh!

mlykotom commented Jun 26, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cartland left a comment

Uh oh!

cartland Jul 2, 2025

Uh oh!

Uh oh!

		@@ -69,6 +82,22 @@ fun CartScreen(onNavBarBack: () -> Unit) {

		val cartState by viewModel.cartUiState.collectAsState()

		CartScreen(

Fruittie screen and ios designs #78

Are you sure you want to change the base?

Fruittie screen and ios designs #78

Uh oh!

Conversation

mlykotom commented Jun 26, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cartland left a comment

Choose a reason for hiding this comment

Uh oh!

cartland Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!