Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[CMCD] DefautDataSource doesn't add headers on master playlist requests #1951

Closed
1 task done
AlexStankevic opened this issue Dec 3, 2024 · 1 comment
Closed
1 task done
Assignees

Comments

@AlexStankevic
Copy link

Version

Media3 1.4.1

More version details

DefautDataSource doesn't add headers on master playlist requests

Devices that reproduce the issue

reproduced on Google Pixel 6 Pro

Devices that do not reproduce the issue

no device

Reproducible in the demo app?

Not tested

Reproduction steps

  1. Add cmcd headers into CMCDConfiguration factory, add it into Datasource
val cmcdConfigurationFactory = CmcdConfiguration.Factory { mediaItem ->
        val cmcdRequestConfig = CmcdConfiguration(
            /* sessionId=*/  UUID.randomUUID().toString() 
            /* contentId= */ UUID.randomUUID().toString() ,
            object : CmcdConfiguration.RequestConfig {})

mediaSourceFactory.setCmcdConfigurationFactory(cmcdConfigurationFactory)

  1. Run any HLS stream

  2. Headers is presents during ts requests, but not presents during m3u8 requests

Expected result

cmcd headers presents in m3u8 requests

Actual result

No cmcd headers in m3u8 requests

Media

https://devstreaming-cdn.apple.com/videos/streaming/examples/adv_dv_atmos/main.m3u8
But can be uses any hls stream

Bug Report

@rohitjoins rohitjoins self-assigned this Dec 4, 2024
copybara-service bot pushed a commit that referenced this issue Dec 10, 2024
@rohitjoins
Copy link
Contributor

Hi @AlexStankevic,

Thank you for bringing this to our attention. We’ve implemented a fix to enable CMCD data on playlist requests.

@androidx androidx locked and limited conversation to collaborators Feb 9, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

2 participants