Support fetching chunks #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Description updated, PTAL |
|
@xmakro - Thanks! Taking a look now. Will get back to you shortly! |
andrusha
approved these changes
Oct 7, 2023
|
@xmakro could you merge with latest main so it runs CI on your PR? |
|
Thanks for the comments! PTAL, the CI requires approval |
|
sorry! got click happy. @dmzmk said to merge before he went on holiday once you had a chance to review! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for fetching record batches which are served by Snowflake over multiple chunk files. In this case, snowflake sends some initial date via base64, and then a list of additional files via the
resp.data.chunksfield.In addition, this PR fixes the authentication session header which was broken in a recent commit. This PR also makes the snowflake-rs API thread-safe so clients can issue concurrent requests.