Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade ESLint packages #235

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Upgrade ESLint packages #235

merged 1 commit into from
Dec 19, 2024

Conversation

andygout
Copy link
Owner

This PR upgrades all ESLint-related packages to their current latest version.

This includes a major upgrade of eslint from v8 to v9 which includes the breaking change of switching from a .eslintrc.json file to a .eslint.config.js file (migration guide).

Also, there is now only a single ESLint config file that sits at the root level rather than additional individual ESLint config files that sit within directories (e.g. test/.eslintrc.json), which have accordingly been removed in this PR.

It seems v9 of ESLint is clever enough to know when comments to disable certain rules are redundant and so this PR also removes those comments that have been flagged in:

  • src/server/app.js

References:

New dev dependencies:

  • globals
    • This is a dependency of eslint. Without globals v15 results in the following: eslint v9 TypeError: Key "languageOptions": Key "globals": Global "AudioWorkletGlobalScope " has leading or trailing whitespace. multiple globals. Installing globals as a direct dependency of this repo is required to ensure that v15 is used.

@andygout andygout merged commit d914ba6 into main Dec 19, 2024
1 check passed
@andygout andygout deleted the upgrade-eslint-packages branch December 19, 2024 15:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant