Added readable error output #196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikedlab why add more steps to find out the error? Why not just include the request body in the error? |
ghostsquad
suggested changes
May 22, 2019
| messages += msg + "\n" | ||
| } | ||
|
|
||
| err := fmt.Errorf("Request failed. Please analyze the request body for more details. Status code: %d\n%s", |
There was a problem hiding this comment.
@nikedlab why add more steps to find out the error? Why not just include the request body in the error?
|
This PR is getting stale. I'll be closing in next week if no one is looking at it. |
ghostsquad
suggested changes
Jun 30, 2019
| err := fmt.Errorf("Request failed. Please analyze the request body for more details. Status code: %d", r.StatusCode) | ||
| var jiraError JiraError | ||
| if jsonErr := json.NewDecoder(r.Body).Decode(&jiraError); jsonErr != nil { | ||
| fmt.Println("Response JSON decoding failed! Error: " + jsonErr.Error()) |
There was a problem hiding this comment.
libraries shouldn't print directly to stdout.
|
Stale PR. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.