Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/pagination #19

Merged
merged 6 commits into from
Jun 12, 2023
Merged

Feature/pagination #19

merged 6 commits into from
Jun 12, 2023

Conversation

angelxmoreno
Copy link
Owner

@angelxmoreno angelxmoreno commented Jun 12, 2023

resolves #7

  • created pagination objects
  • created fetchPaginated method
  • added CakePHP Collections to Memoized Trait
  • added pagination to docs

@codecov-commenter
Copy link

Codecov Report

Merging #19 (93304c1) into main (e6c94bd) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   99.24%   99.37%   +0.12%     
==========================================
  Files           9       11       +2     
  Lines         133      160      +27     
==========================================
+ Hits          132      159      +27     
  Misses          1        1              
Impacted Files Coverage Δ
src/Core/MemoizedTrait.php 100.00% <100.00%> (ø)
src/Core/Pagination/PaginatedResult.php 100.00% <100.00%> (ø)
src/Core/Pagination/Pagination.php 100.00% <100.00%> (ø)
src/Core/Repository/RepositoryBase.php 100.00% <100.00%> (ø)

@codacy-production
Copy link

Coverage summary from Codacy

Merging #19 (93304c1) into main (e6c94bd) - See PR on Codacy

Coverage variation Diff coverage
+0.13% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e6c94bd) 133 132 99.25%
Head commit (93304c1) 160 (+27) 159 (+27) 99.38% (+0.13%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#19) 27 27 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@angelxmoreno angelxmoreno merged commit 494608d into main Jun 12, 2023
@angelxmoreno angelxmoreno deleted the feature/pagination branch June 12, 2023 17:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination
2 participants