This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(typeahead): fixed dropdown menu positioning #276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… one implemented by twitter bootstrap; tests are not green yet
|
@redaemn yeh, I really didn't want to go into the positioning hell with the current typeahead. Going to close this PR now so we can keep only actionable items in the queue. Going to leave some comments in a commit for the future reference. #262 stays opened so we can experiment with different approaches but we've got a work-around so I wouldn't stress about this one right now. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an idea for #262, still a work in progress, tests are not green, just a reference for the future.