Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added ability to queue up children and register them once their parent is registered #492

Merged
merged 1 commit into from
Oct 14, 2013

Conversation

theJoeBiz
Copy link
Contributor

fixes #486

@timkindberg
Copy link
Contributor

And this works across modules too? Could you add test for that?

@nateabele
Copy link
Contributor

Looks like there might be some issues with different ways of defining parents. /cc @mboudreau

@theJoeBiz
Copy link
Contributor Author

@timkindberg Test for across modules added in 104494e

@nateabele You're right. I just added recognition for when the parent property of the state object is a string.

@nateabele
Copy link
Contributor

@theJoeBiz Sounds good. Squash your commits and I'll merge it in.

@theJoeBiz
Copy link
Contributor Author

@nateabele Consider them squashed.

nateabele added a commit that referenced this pull request Oct 14, 2013
Added ability to queue up children and register them once their parent is registered
@nateabele nateabele merged commit 5cac9e7 into angular-ui:master Oct 14, 2013
@timkindberg
Copy link
Contributor

And then make a new issue called "docs for whatever" assigned to me.

@ffesseler
Copy link

Excellent, this will help splitting routes/states in different modules for large app as discussed here : #54

@timkindberg
Copy link
Contributor

docs added, FAQ updated

@theJoeBiz
Copy link
Contributor Author

@timkindberg Docs look good, glad I could help. What kind of timetable are we looking at for 0.3.0 to be available via bower?

@timkindberg
Copy link
Contributor

Don't matter to me. Sooner is probably better.

shql added a commit to shql/ui-router that referenced this pull request Nov 1, 2013
shql added a commit to shql/ui-router that referenced this pull request Nov 1, 2013
StuartCoope2 pushed a commit to StuartCoope/Podium that referenced this pull request Nov 23, 2013
Using States rather than routes.
Had to apply a patch to angular-ui-router:
angular-ui/ui-router#492
This should be fixed when angular-ui-router 0.3 comes out
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idea: Configuring routes without the need for a dependency to call a module
4 participants