Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Commit

Permalink
Reverting #1822 (#1832)
Browse files Browse the repository at this point in the history
* Revert "Bug fix - Search input isn't blocked  (#1822)"
Many problems with this change. Reverted it for this reason.
This reverts commit 0d81493.

* cleaning up comments
  • Loading branch information
Jefiozie authored and aaronroberson committed Oct 23, 2016
1 parent ab89b4e commit f90f743
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions src/uiSelectController.js
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ uis.controller('uiSelectCtrl',
ctrl.select = function(item, skipFocusser, $event) {
if (item === undefined || !_isItemDisabled(item)) {

if ( (!ctrl.items || !ctrl.items.length) && ! ctrl.search && ! ctrl.tagging.isActivated) return;
if ( ! ctrl.items && ! ctrl.search && ! ctrl.tagging.isActivated) return;

if (!item || !_isItemDisabled(item)) {
// if click is made on existing item, prevent from tagging, ctrl.search does not matter
Expand Down Expand Up @@ -611,11 +611,6 @@ uis.controller('uiSelectCtrl',
e.stopPropagation();
}

// if(~[KEY.ESC,KEY.TAB].indexOf(key)){
// //TODO: SEGURO?
// ctrl.close();
// }

$scope.$apply(function() {

var tagged = false;
Expand Down Expand Up @@ -645,9 +640,6 @@ uis.controller('uiSelectCtrl',
});
}
}
}else{
e.preventDefault();
e.stopPropagation();
}

});
Expand Down

2 comments on commit f90f743

@aaronroberson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged and published as 0.19.6. Unfortunately, npm won't let me unpublish 0.19.5.

@Jefiozie
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aaronroberson , is it maybe a idea to use something like semantic-release for publishing the latest version?

Please # to comment.