-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ng serve with esbuild fails to serve directory assets #27044
Labels
area: @angular-devkit/build-angular
devkit/build-angular:dev-server
freq1: low
Only reported by a handful of users who observe it rarely
severity3: broken
type: bug/fix
Comments
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this issue
Feb 7, 2024
…d with Vite dev-server Prior to this commit, the Vite html fallback middleware failed to handle the in-memory assets generated by Angular CLI, resulting in incorrect fallback behavior. For instance, when an `index.html` existed as an asset under a specific path, the generated `index.html` would be served instead. This fix addresses the issue, ensuring that the appropriate `.html` is served when using the Vite dev-server. Closes angular#27044
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this issue
Feb 7, 2024
…d with Vite dev-server Prior to this commit, the Vite html fallback middleware failed to handle the in-memory assets generated by Angular CLI, resulting in incorrect fallback behavior. For instance, when an `index.html` existed as an asset under a specific path, the generated `index.html` would be served instead. This fix addresses the issue, ensuring that the appropriate `.html` is served when using the Vite dev-server. Closes angular#27044
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this issue
Feb 7, 2024
…h Vite dev-server Prior to this commit, the Vite html fallback middleware failed to handle the in-memory assets generated by Angular CLI, resulting in incorrect fallback behavior. For instance, when an `index.html` existed as an asset under a specific path, the generated `index.html` would be served instead. This fix addresses the issue, ensuring that the appropriate `.html` is served when using the Vite dev-server. Closes angular#27044
alan-agius4
added a commit
that referenced
this issue
Feb 7, 2024
…h Vite dev-server Prior to this commit, the Vite html fallback middleware failed to handle the in-memory assets generated by Angular CLI, resulting in incorrect fallback behavior. For instance, when an `index.html` existed as an asset under a specific path, the generated `index.html` would be served instead. This fix addresses the issue, ensuring that the appropriate `.html` is served when using the Vite dev-server. Closes #27044
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this issue
Feb 9, 2024
…d with Vite dev-server Prior to this commit, the Vite html fallback middleware failed to handle the in-memory assets generated by Angular CLI, resulting in incorrect fallback behavior. For instance, when an `index.html` existed as an asset under a specific path, the generated `index.html` would be served instead. This fix addresses the issue, ensuring that the appropriate `.html` is served when using the Vite dev-server. Closes angular#27044
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Labels
area: @angular-devkit/build-angular
devkit/build-angular:dev-server
freq1: low
Only reported by a handful of users who observe it rarely
severity3: broken
type: bug/fix
Which @angular/* package(s) are the source of the bug?
Don't known / other
Is this a regression?
Yes
Description
I have a setup with a non-angular login page, served at path
/#/
. This is included viaassets
inangular.json
:When using
ng serve
with@angular-devkit/build-angular:browser
and callingcurl http://localhost:4200/#/
, the login page is returned.When using
ng serve
with@angular-devkit/build-angular:browser-esbuild
or@angular-devkit/build-angular:application
and callingcurl http://localhost:4200/#/
, the index.html of the angular project is returned.The application redirects to
/#/
if authentication is missing. This results in a redirect loop from / to /# (because angular router does not know about any/#/
route).A work-around is to redirect directly to the
index.html
page (curl http://localhost:4200/#/index.html
works with both esbuild and the old setup), but this is looks a bit ugly.Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
No response
Please provide the environment you discovered this bug in (run
ng version
)Anything else?
No response
The text was updated successfully, but these errors were encountered: