-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
build(@angular/cli): fix @angular dep warnings #4592
Conversation
42cadda
to
391d129
Compare
packages/@angular/cli/package.json
Outdated
"@angular/compiler": ">=2.3.1 <5.0.0", | ||
"@angular/compiler-cli": ">=2.3.1 <5.0.0", | ||
"@angular/core": ">=2.3.1 <5.0.0", | ||
"@angular/tsc-wrapped": "^0.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Angular 4, tac-wrapped
has moved to using the same version.
npm show @angular/tsc-wrapped versions
[ '0.1.0',
'0.2.0',
'0.2.1',
'0.2.2',
'0.3.0',
'0.4.0',
'0.4.1',
'0.4.2',
'0.5.0',
'0.5.1',
'0.5.2',
'4.0.0-beta.2',
'4.0.0-beta.4',
'4.0.0-beta.5',
'4.0.0-beta.6',
'4.0.0-beta.7' ]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
391d129
to
5739e89
Compare
We still need these dependencies as they are peerDeps of @ngtools/webpack. Partially revert angular#4473 Fix angular#4575
5739e89
to
f4c07c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, but tests are failing. I think just a rebase would pass the tests.
We still need these dependencies as they are peerDeps of @ngtools/webpack. Partially revert angular#4473 Fix angular#4575
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
We still need these dependencies as they are peerDeps of @ngtools/webpack.
Partially revert #4473
Fix #4575