Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

anchor linking with # not working in html5mode #648

Closed
mhevery opened this issue Nov 9, 2011 · 3 comments
Closed

anchor linking with # not working in html5mode #648

mhevery opened this issue Nov 9, 2011 · 3 comments

Comments

@mhevery
Copy link
Contributor

mhevery commented Nov 9, 2011

Create an HTML page where the URL is different then the base

current URL: http://localhost:8000/build/docs/some/path

<base href="http://localhost:8000/build/docs/">

crate a link

<a href="#someId">go there</a>

<div id="someId">

when clicked the browser goes to
http://localhost:8000/build/docs#someId
instead to:
http://localhost:8000/build/docs/some/path#someId

@ghost ghost assigned vojtajina Nov 9, 2011
vojtajina added a commit to vojtajina/angular.js that referenced this issue Nov 10, 2011
@mhevery
Copy link
Contributor Author

mhevery commented Nov 10, 2011

This is only a partial fix. The url now no longer gets clobbered, but the second part of this fix needs to be the scrolling to the anchor in the document.

@vojtajina
Copy link
Contributor

That's not a fix, that's feature :-D
I take care of that...

@vojtajina
Copy link
Contributor

Done in my branch https://github.com/vojtajina/angular.js/tree/scroll-to-hash, which is on the top of your injector branch...
Needs to find a name for the service, I really can't think of anything...

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants