This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Naive implementation for better error messages from $interpolate #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }).toThrow('Error while interpolating: {{err()}}\nError: oops'); | ||
| })); | ||
|
|
||
| iit('should stop interpolation when encountering an exception', inject(function($interpolate, $compile, $rootScope) { |
|
landed as d804bbc |
|
I ran into this issue of not having a useful error message. I was going to open a ticket on github, but now I see it has already been solved. Can this be merged into a 1.0.4 release? |
|
it cherry-picks cleanly to v1.0.3 |
|
I used this in production and found my error right away. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not yet complete, but I'm recording this so I don't lose my train of thought and get some feedback. It would be nice to know specifically what part of the interpolation failed. For instance, have the massage distinguish between
foo()andbarthrowing exceptions with input like:{{foo()}} and {{bar()}}. I also still need to add a test for this.Addresses issue #832.