Skip to content

Checking for window.performance.mark, may fix #2812 #2813

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 2 commits into from

Conversation

spicemix
Copy link

@spicemix spicemix commented May 4, 2021

Checklist

  • Issue number for this PR: AngularFirePerformance incompatible with Jest #2812 (required)
  • Docs included?: no (yes/no; required for all API/functional changes)
  • Test units included?: no (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? yes (yes/no; required)

Description

Trivial bugfix for Jest compatibility

Code sample

spicemix added 2 commits May 4, 2021 00:42
For compatibility with test environments that replace window.performance
For compatibility with test environments that replace window.performance
@jamesdaniels
Copy link
Member

Thanks, resolving merge conflicts here #2920

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants