Skip to content

Fix properties in deploy schema that require oneOf #3092

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

kfrancois
Copy link
Contributor

Use oneOf instead of "type": ["a", "b"] to fix the ng deploy command.

Currently, running ng deploy with the @angular/fire:deploy builder results in the following error:

Property 'ssr' does not match the schema.
{
  "type": [
    "boolean",
    "string"
  ],
  "description": "Should we attempt to deploy the function to Cloud Functions (true or 'cloud-functions') / Cloud Run ('cloud-run') or just Hosting (false)"
}'

Running the same command with the proposed changes results in a successful deploy.

Checklist

Description

Code sample

Use `oneOf` instead of `"type": ["a", "b"]` to fix the `ng deploy` command
@jamesdaniels jamesdaniels enabled auto-merge (squash) January 6, 2022 20:38
@jamesdaniels
Copy link
Member

Thanks for the fix!

@jamesdaniels jamesdaniels disabled auto-merge February 7, 2022 05:14
@jamesdaniels jamesdaniels merged commit 058d624 into angular:master Feb 7, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants