This repository was archived by the owner on Dec 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
'[ng:app] not a valid selector #36
Comments
Turns out those selectors aren't escaped properly. Are you using BlockingProxy directly, or are you using it through Protractor? Also, is this an AngularJS app? I'm guessing most people haven't hit this code path yet since they tend to either have the app on document.body or are passing a root element. |
Turns out this was fixed upstream in Protractor, that's what I get for just copying the client side scripts. angular/protractor#4021 |
heathkit
added a commit
to heathkit/blocking-proxy
that referenced
this issue
Mar 10, 2017
heathkit
added a commit
that referenced
this issue
Mar 10, 2017
Thanks for the quick turnaround! I'm using Blocking Proxy directly, and I only have the |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
I keep getting the following error on my tests:
I removed both
trySelector('[ng:app]')
andtrySelector('[ng:controller]')
in https://github.com/angular/blocking-proxy/blob/master/lib/client_scripts/wait.js#L111, and my tests are working now.I don't know enough to say if those
trySelector
calls need to be there or not. But perhaps the method should also be surrounded by atry-catch
like thetryEl
method?The text was updated successfully, but these errors were encountered: