Skip to content

[PATCH] Migrate to use rules_js based ng_package #30917

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 22, 2025
Merged

[PATCH] Migrate to use rules_js based ng_package #30917

merged 8 commits into from
Apr 22, 2025

Conversation

josephperrott
Copy link
Member

No description provided.

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release area: build & ci Related the build and CI infrastructure of the project labels Apr 21, 2025
@josephperrott josephperrott requested a review from mmalerba April 21, 2025 17:41
@josephperrott josephperrott requested review from a team as code owners April 21, 2025 17:41
@josephperrott josephperrott requested review from adolgachev and removed request for a team and adolgachev April 21, 2025 17:41
@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label Apr 21, 2025
@mmalerba
Copy link
Contributor

@josephperrott I'm not really sure how this test is related to what you changed, but it does seem to be consistently failing for this PR

@josephperrott
Copy link
Member Author

@mmalerba These failures are already failing on upstream. I was just waiting for them to be corrected and I would rebase so it would go green.

@josephperrott josephperrott force-pushed the replace-ng-package-patch branch from 705181d to ea76d1e Compare April 22, 2025 14:03
@mmalerba
Copy link
Contributor

Oh I see, I didn't realize this was targeting 19.2.x, I saw that main was green. I'll look into what's going on with the patch branch

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Apr 22, 2025
@mmalerba mmalerba force-pushed the replace-ng-package-patch branch from ea76d1e to f64bfce Compare April 22, 2025 18:05
@mmalerba mmalerba merged commit 89db9f7 into angular:19.2.x Apr 22, 2025
21 of 22 checks passed
mmalerba added a commit to mmalerba/components that referenced this pull request Apr 22, 2025
@mmalerba
Revert "[PATCH] Migrate to use rules_js based ng_package (angular#30917…
e278fa7 
…)"

This reverts commit 89db9f7.
mmalerba added a commit that referenced this pull request Apr 22, 2025
@mmalerba
Revert "[PATCH] Migrate to use rules_js based ng_package (#30917)" (#…
64795cc 
…30928)

This reverts commit 89db9f7.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephperrott @mmalerba