Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(tooltip): unable to reopen when closed by detaching overlay #8232

Merged
merged 1 commit into from
Nov 10, 2017
Merged

fix(tooltip): unable to reopen when closed by detaching overlay #8232

merged 1 commit into from
Nov 10, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 4, 2017

Fixes not being able to reopen a tooltip that was closed via OverlayRef.detach (e.g. by the CloseScrollStrategy).

@crisbeto
fix(tooltip): unable to reopen when closed by detaching overlay
de27b09 
Fixes not being able to reopen a tooltip that was closed via `OverlayRef.detach` (e.g. by the `CloseScrollStrategy`).
@crisbeto crisbeto added the in progress This issue is currently in progress label Nov 4, 2017
@crisbeto crisbeto self-assigned this Nov 4, 2017
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 4, 2017
@crisbeto crisbeto assigned andrewseguin and unassigned crisbeto Nov 4, 2017
@crisbeto crisbeto added pr: needs review and removed in progress This issue is currently in progress labels Nov 4, 2017
@crisbeto crisbeto mentioned this pull request Nov 4, 2017
Merged
jelbourn
jelbourn approved these changes Nov 8, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 8, 2017
@josephperrott josephperrott merged commit 0719c38 into angular:master Nov 10, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @jelbourn @googlebot @josephperrott @andrewseguin