Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(focus-trap): server-side rendering error #9001

Merged
merged 1 commit into from
Jan 4, 2018

Conversation

crisbeto
Copy link
Member

Fixes a server-side rendering error due to the Node class not being being available in Universal.

Fixes #8981.

Fixes a server-side rendering error due to the `Node` class not being being available in Universal.

Fixes angular#8981.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 14, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Dec 15, 2017
@jelbourn jelbourn merged commit c77f69f into angular:master Jan 4, 2018
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 8, 2018
Fixes a server-side rendering error due to the `Node` class not being being available in Universal.

Fixes angular#8981.
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 9, 2018
Fixes a server-side rendering error due to the `Node` class not being being available in Universal.

Fixes angular#8981.
jelbourn pushed a commit that referenced this pull request Jan 9, 2018
Fixes a server-side rendering error due to the `Node` class not being being available in Universal.

Fixes #8981.
tinayuangao pushed a commit that referenced this pull request Jan 10, 2018
Fixes a server-side rendering error due to the `Node` class not being being available in Universal.

Fixes #8981.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FocusTrap: 'Node is not defined' in server side rendering
4 participants