Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(chips): Add chips bottom margin #9044

Closed
wants to merge 1 commit into from
Closed

fix(chips): Add chips bottom margin #9044

wants to merge 1 commit into from

Conversation

tinayuangao
Copy link
Contributor

@tinayuangao tinayuangao commented Dec 19, 2017 •
edited
Loading

Fixes #8587

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 19, 2017
@tinayuangao tinayuangao requested a review from jelbourn December 19, 2017 00:50
@tinayuangao tinayuangao added target: patch This PR is targeted for the next patch release pr: needs review labels Dec 19, 2017
@josephperrott
Copy link
Member

I think that last time we included this spacing we saw issues with the spacing between sibling chips: #8180 which was fixed by #8198

@tinayuangao
Copy link
Contributor Author

Yes, you are right. We should find another way to fix this.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chip input: no margin between chips in multiple lines
3 participants
@tinayuangao @josephperrott @googlebot