Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(chips): Remove chip bottom margin in sibling chips #8198

Merged
merged 1 commit into from
Nov 10, 2017
Merged

fix(chips): Remove chip bottom margin in sibling chips #8198

merged 1 commit into from
Nov 10, 2017

Conversation

tinayuangao
Copy link
Contributor

Fixes #8180

josephperrott
josephperrott approved these changes Nov 2, 2017
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 2, 2017
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 2, 2017
jelbourn
jelbourn approved these changes Nov 3, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott merged commit d79903a into angular:master Nov 10, 2017
josephperrott added a commit that referenced this pull request Nov 10, 2017
@josephperrott
Revert "fix(chips): remove chip bottom margin in sibling chips (#8198)"
6f35b89 
This reverts commit d79903a.
@merobal merobal mentioned this pull request Nov 22, 2017
Closed
@josephperrott josephperrott mentioned this pull request Dec 19, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent chip bottom margin in mat-chip-list
4 participants
@tinayuangao @jelbourn @josephperrott @googlebot