-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Tsickle distribution package contains multiple amd-module declaratios. #846
Comments
4 tasks
Amusingly, we don't write this comment, so it might be a bug in how TypeScript generates its d.ts files (?) |
It's a bug in the bazel ts_library build rules - somewhere around this https://github.com/bazelbuild/rules_typescript/blob/c7b6880767eaae44d8777a7a1b137de92b8fd4d9/internal/tsc_wrapped/compiler_host.ts#L385 |
Nice find! It looks like the bug it was working around was fixed in TS 2.9, so that's why it double-emits. |
rkirov
added a commit
that referenced
this issue
Jun 28, 2018
This is to fix #846, since we don't have push rights to rules_typescript, for now just point to a custom fork for the repo.
rkirov
added a commit
that referenced
this issue
Jun 28, 2018
This is to fix #846, since we don't have push rights to rules_typescript, for now just point to a custom fork for the repo.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
The v0.30.0 distribution of Tsickle is invalid. some files contain
amd-module
declarations more than once. Having multiple declarations ofamd-module
is invalid TypeScript file.Example:
node_modules/tsickle/src/googmodule.d.ts
Here is a full list of offending files:
The text was updated successfully, but these errors were encountered: