Skip to content

Commit

Permalink
fix tests and lint
Browse files Browse the repository at this point in the history
  • Loading branch information
anigenero committed Mar 12, 2021
1 parent 4ce9bba commit d988253
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 65 deletions.
50 changes: 18 additions & 32 deletions src/__tests__/Component.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ export const taskReducer: Reducer<TaskState, TaskReducerAction> = (prevState, ac

export namespace ReducerEpics {

export const startTask: Epic<TaskAction, TaskAction, TaskState, Dependencies> =
(action$, state$, {service}) =>
export const startTask: Epic<TaskAction, TaskAction, Dependencies> =
(action$, {service}) =>
action$.pipe(
ofType(TaskActionTypes.START_TASK),
switchMap(({task}) =>
Expand All @@ -101,8 +101,8 @@ export namespace ReducerEpics {
)
);

export const badTask: Epic<TaskAction, TaskAction, TaskState, Dependencies> =
(action$, state$, {service}) => null;
export const badTask: Epic<TaskAction, TaskAction, Dependencies> =
() => null;

}

Expand Down Expand Up @@ -138,9 +138,10 @@ describe('createObservableReducerContext', () => {

it('should create context', () => {

const {Provider, useObservableContext} = createObservableReducerContext(taskReducer, [
ReducerEpics.startTask
], {service: serviceFunction});
const {Provider, useObservableContext} = createObservableReducerContext<TaskAction, TaskState, Reducer<TaskState, TaskAction>>(
taskReducer, [
ReducerEpics.startTask
], {service: serviceFunction});

const tree = create(
<Provider options={{state: defaultState}}>
Expand All @@ -155,9 +156,11 @@ describe('createObservableReducerContext', () => {

it('should dispatch event', () => {

const {Provider, useObservableContext} = createObservableReducerContext(taskReducer, [
ReducerEpics.startTask
], {service: serviceFunction});
const {Provider, useObservableContext} = createObservableReducerContext<TaskAction, TaskState, Reducer<TaskState, TaskAction>>(
taskReducer, [
ReducerEpics.startTask
], {service: serviceFunction}
);

const wrapper = mount(
<Provider options={{state: defaultState}}>
Expand All @@ -179,9 +182,11 @@ describe('createObservableReducerContext', () => {

it('should error out for bad stream', () => {

const {Provider, useObservableContext} = createObservableReducerContext(taskReducer, [
ReducerEpics.badTask
], {service: serviceFunction});
const {Provider, useObservableContext} = createObservableReducerContext<TaskAction, TaskState, Reducer<TaskState, TaskAction>>(
taskReducer, [
ReducerEpics.badTask
], {service: serviceFunction}
);

const tree = create(
<Provider options={{state: defaultState}}>
Expand All @@ -194,23 +199,4 @@ describe('createObservableReducerContext', () => {

});

it('should error out for bad stream on dispatch', () => {

const {Provider, useObservableContext} = createObservableReducerContext(taskReducer, null, {service: serviceFunction});

const wrapper = mount(
<Provider options={{state: defaultState}}>
<TaskComponent taskName="test"
useContext={useObservableContext as any}/>
</Provider>
);

const btn = wrapper.find('#bad-dispatch-btn');
btn.simulate('click');

expect(toJson(wrapper)).toMatchSnapshot();


});

});
28 changes: 0 additions & 28 deletions src/__tests__/__snapshots__/Component.spec.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -81,31 +81,3 @@ exports[`createObservableReducerContext should error out for bad stream 1`] = `
/>
</div>
`;

exports[`createObservableReducerContext should error out for bad stream on dispatch 1`] = `
<Provider
options={
Object {
"state": Object {
"task": null,
},
}
}
>
<TaskComponent
taskName="test"
useContext={[Function]}
>
<div>
<button
id="task-dispatch-btn"
onClick={[Function]}
/>
<button
id="bad-dispatch-btn"
onClick={[Function]}
/>
</div>
</TaskComponent>
</Provider>
`;
5 changes: 0 additions & 5 deletions src/__tests__/ofType.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,4 @@ describe('ofType', () => {
expect(ofType(undefined)).toThrowError();
});

it('should throw argument length error', () => {
// @ts-ignore
expect(ofType()).toThrowError();
});

});

0 comments on commit d988253

Please # to comment.